Skip to content

infra[notask]: fix the SDK e2e models cache key #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Victor-Rodzko wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

infra[notask]: fix the SDK e2e models cache key #4592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/test-node-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,13 +414,17 @@ jobs:
console.log(`SDK cache dir: ${cacheDir}`);
console.log(`Config written to: ${configPath}`);

# The key carries the consumer: bootstrap:desktop pre-downloads a strict
# superset of bootstrap:electron, so a shared key let whichever consumer
# bootstrapped first pin the entry to its own set, and the other consumer
# then re-downloaded the difference on every run without ever saving it.
- name: Restore models cache
id: models-cache
if: inputs.consumer != 'snap' && inputs.cache-models != false
uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # 5.0.4
with:
path: ${{ inputs.working-directory }}/.qvac-cache
key: qvac-models-${{ hashFiles('packages/sdk/models/registry/models.ts') }}
key: qvac-models-${{ inputs.consumer }}-${{ hashFiles('packages/inference/src/models/registry/models.ts') }}
enableCrossOsArchive: true

- name: Bootstrap (download models)
Expand All @@ -435,7 +439,7 @@ jobs:
uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # 5.0.4
with:
path: ${{ inputs.working-directory }}/.qvac-cache
key: qvac-models-${{ hashFiles('packages/sdk/models/registry/models.ts') }}
key: qvac-models-${{ inputs.consumer }}-${{ hashFiles('packages/inference/src/models/registry/models.ts') }}
enableCrossOsArchive: true

- name: Build Electron package
Expand Down Expand Up @@ -564,7 +568,7 @@ jobs:
uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # 5.0.4
with:
path: ~/snap/qvac-sdk-e2e/common/.qvac/models
key: qvac-snap-models-${{ hashFiles('packages/sdk/models/registry/models.ts') }}
key: qvac-snap-models-${{ hashFiles('packages/inference/src/models/registry/models.ts') }}

- name: Bootstrap models inside Snap
if: inputs.consumer == 'snap' && steps.snap-model-requirements.outputs.required == 'true' && steps.snap-models-cache.outputs.cache-hit != 'true'
Expand All @@ -580,7 +584,7 @@ jobs:
uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # 5.0.4
with:
path: ~/snap/qvac-sdk-e2e/common/.qvac/models
key: qvac-snap-models-${{ hashFiles('packages/sdk/models/registry/models.ts') }}
key: qvac-snap-models-${{ hashFiles('packages/inference/src/models/registry/models.ts') }}

- name: Generate runId
if: always()
Expand Down
Loading