test[translation-nmtcpp]: bounded FuzzTest for GGML weight-header parsers - #4594
Open
jpgaribotti wants to merge 1 commit into
Open
jpgaribotti wants to merge 1 commit into
jpgaribotti wants to merge 1 commit into
Conversation
The n_dims stack overflow in tetherto#4590 was a length-field parse bug that unit tests only catch once the case is known. A no-fabric FuzzTest over the extracted parsers reaches n_dims>4, oversized names, and short reads on every Linux C++ CI run.
jpgaribotti
requested a deployment
to
fork-ci
September 18, 2026 18:31 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
jpgaribotti
requested a deployment
to
fork-ci
September 18, 2026 18:31 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
jpgaribotti
requested a deployment
to
fork-ci
September 18, 2026 18:31 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
n_dims > 4. Nearby length-prefixed fields (nmtReadBoundedString,nmtReadCount, tensor type) have the same shape.n_dims=8case, and keeps the reject paths reachable on every Linux C++ CI run.📝 How does it solve it?
nmt_loader_parse.cppso the fuzz target compiles them without@qvac/fabric(full ASan + LeakSanitizer).nmt-weight-header-fuzzwith seededFUZZ_TESTs, including then_dims=8crash from Fix NMT ndims overflow crash #4590.fuzz*scripts, the vcpkgfuzzfeature, and Linuxnpm run fuzzafter the coverage harvest inreusable-cpp-tests-translation-nmtcpp.yml.@qvac/translation-nmtcpp0.16.4→0.16.5. No public addon API changes.🧪 How was it tested?
classification-ggmlPhase 0 template (docs/architecture/ADDON-FUZZING.md).npm run fuzz:build+npm run fuzz:run).on-pr-*ispull_request_targetand reads workflow YAML frommain, so the new fuzz steps run after this lands, not on this PR itself.