test[ocr-ggml]: bounded FuzzTest for image decode and size overflow guards - #4597
Open
jpgaribotti wants to merge 1 commit into
Open
jpgaribotti wants to merge 1 commit into
jpgaribotti wants to merge 1 commit into
Conversation
jpgaribotti
requested a deployment
to
fork-ci
September 18, 2026 18:32 — with
GitHub Actions
Waiting
jpgaribotti
requested a deployment
to
fork-ci
September 18, 2026 18:32 — with
GitHub Actions
Waiting
jpgaribotti
requested a deployment
to
fork-ci
September 18, 2026 18:32 — with
GitHub Actions
Waiting
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
decodeOrWrapImageis the OCR addon's untrusted-input front door: encoded JPEG/PNG bytes, or a raw bitmap with attacker-controlled width / height / bpp.intforcv::Mat, and rawwidth * height * bppcould wrapsize_t— the same overflow class as the NMTn_dimscrash in Fix NMT ndims overflow crash #4590.📝 How does it solve it?
decodeOrWrapImageintoDecodeImage.cppso it can be fuzzed without@qvac/fabric.int, and raw bitmaps whose width × height × bpp overflowssize_t.ocr-decode-image-fuzz(OpenCV only, full ASan + LSan) with a generated PNG seed and raw size-mismatch seeds.cpp-tests-ocr.ymland wire it fromon-pr-ocr-ggml.yml.@qvac/ocr-ggml0.24.3→0.24.4. No public addon API changes.🧪 How was it tested?
classification-ggmlPhase 0 template (docs/architecture/ADDON-FUZZING.md).npm run fuzz:build+npm run fuzz:run).on-pr-ocr-ggml.ymlispull_request_targetand reads workflow YAML frommain, so the new fuzz job runs after this lands, not on this PR itself.