feat: support smart quote#37
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds proper handling for Typst smart quote nodes by converting them into standard textlint Str nodes, aligning emitted AST with other inline text content and updating documentation/fixtures accordingly.
Changes:
- Convert
Marked::SmartQuotenodes toStr(withvaluederived from the raw source). - Remove
Marked::SmartQuotefrom the “inline marked” paragraphization classification (no longer needed once converted toStr). - Update the smart-quote fixture output and the README syntax support table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/typstToTextlintAst.ts |
Converts Marked::SmartQuote to Str during AST conversion and adjusts inline-marked classification. |
test/unit/fixtures/inline-escape-shorthand-smartquote/output.json |
Updates expected AST output to reflect Str nodes for smart quotes. |
README.md |
Marks smart quotes as supported and documents their mapping to Str. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.