Add a few test cases for simple situations#322
Conversation
|
More tests are welcome, especially if they touch on situations that aren't already covered. I would merge the "Child Widgets" tests because more explicit tests are never bad, but they are unlikely to add much value because this is already covered by the Container tests. They might protect against a future case where Panel would override the add or remove functions, but if tests are done properly then new tests would be written together with such a change to Panel anyway. Time might be better spend writing tests for parts of the code that are untested or partially untested. You can use https://app.codecov.io/github/texus/TGUI to see which part of the code is covered by the tests. The addition in SignalManager.cpp doesn't seem to have anything to do with SignalManager (which is an actual class for an edge-case situation, not the place to tests signals). The signal class itself (so e.g. |
f9ead2b to
fd04d51
Compare
|
Thank you for the feedback. |
|
Added a test for FileDialog::[get/set]CreateFolderButtonText that didn't previously have any test coverage. I won't touch this branch any further, but will add more tests in a future PR if you are happy with this stuff :) |
Hi Texus
This is just a "feeler PR" to find out if you will appreciate additions to the test suite.
These tests are fairly basic (but relevant IMHO).
I'll add more in the future if you like them - just don't want to waste a bunch of time writing tests if you don't want them :)