Add Bot Manager for Bot Lifecycle Coordination#113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98
Summary
Implements
BotManager, the central coordinator for bot lifecycle management in the Bot Service. This component bridges the REST API layer with bot runners and WebSocket clients, enabling spawning bots into game rooms, loading trained neural network models from the ModelRegistry, and managing multiple concurrent bot instances.Changes Made
bot2/
BotManagerclass inbot/service/bot_manager.pywith full lifecycle management:spawn_bot()creates bots and connects them in background tasksdestroy_bot()gracefully stops and removes botsget_bot()andlist_bots()for status querieslist_models()returns available models from registryshutdown()for graceful service terminationBotConfig,SpawnBotRequest,SpawnBotResponse,BotInfoclientparameter (set later byWebSocketBotClient)bot/service/__init__.pyImplementation Details
bot_{uuid_hex[:12]}asyncio.create_task()allows immediate API response while bot connectsBotConfigvalidates that rule-based bots cannot specify model parameters, and neural network bots must provide eithermodel_idorgenerationTesting