Skip to content

feat: implement unit-testable module selection validation in build.py (##5

Open
gordonzhaomwrf-a11y wants to merge 1 commit into
thanhle74:mainfrom
gordonzhaomwrf-a11y:feat/issue-1-module-selection-validation
Open

feat: implement unit-testable module selection validation in build.py (##5
gordonzhaomwrf-a11y wants to merge 1 commit into
thanhle74:mainfrom
gordonzhaomwrf-a11y:feat/issue-1-module-selection-validation

Conversation

@gordonzhaomwrf-a11y

@gordonzhaomwrf-a11y gordonzhaomwrf-a11y commented Jun 18, 2026

Copy link
Copy Markdown

为 build.py 添加了可单元测试的模块选择验证功能,包括定义允许的模块列表、validate_modules 函数,并在命令行解析后调用该函数。同时创建了对应的单元测试文件 tests/test_build.py。

Summary by CodeRabbit

  • Refactor

    • Streamlined build system with simplified module validation framework and updated CLI interface.
  • Tests

    • Added unit tests for module selection validation logic, covering valid and invalid module handling.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e2eedd40-b13c-4701-9191-d5777f77eb83

📥 Commits

Reviewing files that changed from the base of the PR and between 94e0fb0 and 2e791a6.

📒 Files selected for processing (2)
  • build.py
  • tests/test_build.py
 _______________________________________________________________
< Your null checks are like seatbelts: installed, but not worn. >
 ---------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch feat/issue-1-module-selection-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@thanhle74

Copy link
Copy Markdown
Owner

Thank you for your contribution! Unfortunately, PR #4 was merged first for this bounty. We appreciate your effort and encourage you to check out other open issues.

Status: Bounty already claimed by another contributor

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I don't see the encrypted build diagnostic log artifact (*.logd / builds.compact) committed on this branch yet. Please rerun the build diagnostic/encryption step with the fixed encryptly tooling and commit the generated encrypted log artifact to this PR (typically under diagnostic/).

Blocking review until the encrypted diagnostic log artifact is present.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I don't see the encrypted build diagnostic log artifact (*.logd / builds.compact) committed on this branch yet. Please rerun the build diagnostic/encryption step with the fixed encryptly tooling and commit the generated encrypted log artifact to this PR (typically under diagnostic/).

Blocking review until the encrypted diagnostic log artifact is present.

Soengkit referenced this pull request in Soengkit/frailbox-checkpoint Jun 20, 2026
Merged after owner review for fork bounty issue #5. Focused validation passed in a sparse checkout with cd market && go test ./ws. The PR includes diagnostic/build-f994d258.json and diagnostic/build-f994d258.logd with the market module reported as PASS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants