Make playback pause a no-op on macOS#165
Merged
Merged
Conversation
nowplaying-cli 2.1.0 works around Apple's macOS 15.4+ MediaRemote lockdown by spawning a perl helper via mediaremote-adapter. That helper can outlive our `timeout 2` guard and hold the hook's stdout pipe open, hanging Claude Code's Stop/Notification hooks until their 60s timeout. Skip media control entirely on Darwin; the playerctl path on Linux is unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playback --pause-distractionsClaude hooks were frequently hanging on macOS. Root cause: nowplaying-cli 2.1.0 works around Apple's macOS 15.4+ MediaRemote lockdown by spawning a perl helper (via mediaremote-adapter). That helper can outlive the script'stimeout 2guard and hold the hook's stdout pipe open, so Claude Code waits on the hook until its 60s timeout.playbacka no-op on Darwin — exit 0 before touching any backend. The Linuxplayerctlpath is unchanged.Test plan
bash -n bin/playbackplayback --pause-distractionson macOS returns immediately with exit 0 (~0.25s)make lint🤖 Generated with Claude Code