change writeHash to use a default parameter instead of bind (#17)#18
Open
kinland wants to merge 1 commit intothdk:masterfrom
Open
change writeHash to use a default parameter instead of bind (#17)#18kinland wants to merge 1 commit intothdk:masterfrom
kinland wants to merge 1 commit intothdk:masterfrom
Conversation
Owner
|
Hi, thanks for your effort. I like your approach as it keeps the library simple without requiring too much knowledge of package managers logic. However, I think we can add a helper function to the library So your example usage would become: /** @type {import('package-changed/types')} */
const { isPackageChanged, writeHash } = require('package-changed');
/** @type {import('child_process')} */
const { execSync } = require('node:child_process');
(async () => {
const { oldHash, hash: rootHash } = await isPackageChanged({ noHashFile: true });
const { hash: nextjsHash } = await isPackageChanged({ noHashFile: true, cwd: './nextjs' });
const newHash = `${rootHash}${nextjsHash}`;
if (newHash !== oldHash) {
console.log("Package changed. Running 'rm -f .eslintcache && pnpm install'.");
// dependencies in a package.json have changed since last run
execSync('rm -f .eslintcache');
execSync('pnpm install');
writeHash(newHash);
}
})(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows you to write a custom hash. This is primarily a workaround for #16
With these changes, I can now do something like