Skip to content

feat: expand curated SIDC catalog - #16

Merged
the-Drunken-coder merged 2 commits into
mainfrom
codex/expand-curated-catalog
Jun 26, 2026
Merged

the-Drunken-coder merged 2 commits into
mainfrom
codex/expand-curated-catalog

Conversation

@the-Drunken-coder

@the-Drunken-coder the-Drunken-coder commented Jun 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • expand the curated semantic catalog from land-unit examples to verified air, sea surface, sea subsurface, land equipment, land installation, and control-measure fixtures
  • keep the existing public API unchanged while adding searchable aliases and structured parts for the new entries
  • update README coverage notes to describe the curated sample scope without implying exhaustive MIL-STD-2525/APP-6 coverage

Validation

  • npm test
  • npm pack --dry-run

Scope limits

  • intentionally not an exhaustive MIL-STD-2525/APP-6 catalog
  • reverse lookup and generated full-corpus imports remain deferred
  • added entries were selected only when they rendered successfully with the installed milsymbol package

Greptile Summary

This PR expands and reorganizes the curated SIDC catalog.

  • Adds domain-specific catalog modules for air, maritime, equipment, installations, and control measures.
  • Keeps the existing symbol data entry point as a re-export shim.
  • Adds round-trip tests for rendering, explaining, searching, and building curated SIDCs.
  • Updates README coverage wording for the broader curated sample set.

Confidence Score: 5/5

The curated catalog expansion preserves the existing public entry point while adding the requested domain-specific data modules.

No code issues were identified in the finalized review. Runtime validation also exercised representative catalog entries across the newly claimed domains, public API compatibility, tests, and package dry-run behavior without finding a contract mismatch.

None.

T-Rex T-Rex Logs

What T-Rex did

  • Before the PR, a base run failed at runtime because dist/data/catalog/index.js was not present on base, as seen in trex-artifacts/catalog-contract-01-before.log.
  • After the PR head, npm test passed (16/16), catalogCount is 20, shimCompatible is true, and allOk is true for six representative new domains, with npm pack --dry-run listing the expected public data entry points, as shown in trex-artifacts/catalog-contract-02-after.log.
  • Representative head checks for air fighter, sea surface destroyer, hostile sea subsurface submarine, land equipment tank, land installation airport, and control measure checkpoint all passed.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "refactor: split curated catalog files" | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Jun 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@the-Drunken-coder, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 40 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 93e37796-14f2-41d7-80ad-fa764a09a66e

📥 Commits

Reviewing files that changed from the base of the PR and between 3b6285b and ec5bd5c.

📒 Files selected for processing (12)
  • README.md
  • src/data/catalog/air.ts
  • src/data/catalog/control-measures.ts
  • src/data/catalog/index.ts
  • src/data/catalog/land-equipment.ts
  • src/data/catalog/land-installations.ts
  • src/data/catalog/land-units.ts
  • src/data/catalog/sea-subsurface.ts
  • src/data/catalog/sea-surface.ts
  • src/data/catalog/types.ts
  • src/data/symbols.ts
  • test/sidc-kit.test.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/expand-curated-catalog

Comment @coderabbitai help to get the list of available commands.

@the-Drunken-coder

Copy link
Copy Markdown
Owner Author

@codex review

@the-Drunken-coder

Copy link
Copy Markdown
Owner Author

@greptileai review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: ec5bd5cf7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@the-Drunken-coder
the-Drunken-coder marked this pull request as ready for review June 25, 2026 20:06
@the-Drunken-coder
the-Drunken-coder merged commit fe2f72c into main Jun 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant