Skip to content

Add curated fixture generator - #19

Merged
the-Drunken-coder merged 2 commits into
mainfrom
codex/add-fixture-generator
Jun 26, 2026
Merged

the-Drunken-coder merged 2 commits into
mainfrom
codex/add-fixture-generator

Conversation

@the-Drunken-coder

@the-Drunken-coder the-Drunken-coder commented Jun 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add a JSON source for curated land-unit fixtures and generate src/data/symbols.ts from it.
  • Validate generated SIDCs preserve the known number-SIDC field positions and render with the installed milsymbol package.
  • Wire fixture checks into npm test/prepack and document the regenerate/check commands.

Validation

  • npm test
  • npm pack --dry-run

Scope limits

  • Keeps the current curated fixture set unchanged.
  • Does not add broader SIDC corpus coverage or image/reverse lookup.

Greptile Summary

This PR adds a curated fixture generator for land-unit symbols. The main changes are:

  • Adds a JSON source for curated land-unit fixtures.
  • Generates src/data/symbols.ts from the fixture source.
  • Validates generated SIDCs against milsymbol metadata and rendering.
  • Adds fixture check and generation commands to npm scripts.
  • Documents the fixture workflow in the README.

Confidence Score: 5/5

The curated fixture generation, validation, test, and package lifecycle paths are working as intended.

No code issues were identified. The fixture workflow was exercised through generation checks, drift detection, the test suite, and package dry-run behavior, with the expected validation coverage for SIDC field positions and milsymbol rendering.

None.

T-Rex T-Rex Logs

What T-Rex did

  • The team attempted to generate curated fixtures before dependencies were installed; the generate-curated-fixtures -- --check script name was absent and npm test/npm pack failed because milsymbol was not installed.
  • After dependencies were installed, npm install completed, fixture checks were run and regeneration succeeded, an intentional drift was detected, and the fixture check was restored.
  • The test suite and packaging checks ran; npm test executed with check:fixtures and build, covering 11 node tests with 0 failures, including land-unit fixture field-position and milsymbol rendering coverage, and npm pack --dry-run completed successfully.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "fix: harden fixture generator checks" | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Jun 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@the-Drunken-coder, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 9 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eba350e0-44a8-4917-a2b1-ef621495faca

📥 Commits

Reviewing files that changed from the base of the PR and between 3b6285b and d09cad5.

📒 Files selected for processing (5)
  • README.md
  • fixtures/curated-land-units.json
  • package.json
  • scripts/generate-curated-fixtures.mjs
  • src/data/symbols.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/add-fixture-generator

Comment @coderabbitai help to get the list of available commands.

@the-Drunken-coder

Copy link
Copy Markdown
Owner Author

@codex review

@the-Drunken-coder

Copy link
Copy Markdown
Owner Author

@greptileai review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: d569f6540a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/generate-curated-fixtures.mjs Outdated
Comment thread scripts/generate-curated-fixtures.mjs
@the-Drunken-coder
the-Drunken-coder marked this pull request as ready for review June 25, 2026 20:06
@the-Drunken-coder
the-Drunken-coder merged commit 0bbe038 into main Jun 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant