fix(articles): five defects found reviewing the editor

[aquie00t]

A review pass over the articles feature, with attention on the writing half. Each defect was reproduced with a failing test on main before it was fixed.

Ordered by what they cost.

1. A lost edit — silent data loss

Type, pause, keep typing while the save is still in flight, and the second batch never reaches the server.

save refuses to run concurrently and returns early, and the autosave effect does not re-fire for that edit — its dependencies are unchanged by the time the request resolves. Nothing reported it either: the indicator sat on "unsaved changes" and the writer had to type again to shake it loose. On a slow connection this is exactly the moment you would lose a paragraph.

Saves now chain: one more runs if the draft moved on while a save was open. Publish flushes the same chain, so it cannot put older text live.

2. The editor was not keyed by the article it edits

useArticleEditor seeds in useState initialisers, which run once per mount. Moving from one article's edit URL to another kept the first article's text on screen while the URL claimed the second — and the next autosave wrote it back to whichever id the hook was still holding.

A comment above the component already claimed it was keyed. It wasn't. Now it is.

3. A wasted request on every new article

Opening /articles/new called the loader with an empty slug, spending a PUBLIC-limited request on a URL that answers with nothing useful.

Worth calling out: the existing test asserted that call, so the defect was pinned in place rather than caught. Loading is now a separate component that only mounts when there is something to load — which also gives that path the retry it was missing.

4. The Worker spliced the slug into the API path unencoded

The slug comes straight off the request URL, where percent-escapes survive the route match. %2f is not a separator to the URL parser, so it arrives inside a single segment and reaches the API as a slash, resolving a different route than the one intended.

Low severity — the value cannot escape the path into the authority, and everything injected into meta tags is still escaped — but the client-side API module already encoded, so this was an inconsistency with a sharp edge. Now matched.

5. A reply box with nowhere to send

A comment carrying neither postId nor articleId would have posted to /articles//comments. The empty-string fallback is gone; the target is narrowed once, and the box is not offered when there is no parent. Also removes a ! assertion the API notes explicitly warn against.

What I checked and found clean

Markdown sanitisation (skipHtml, no rehype-raw, tests in place), cover and avatar URLs through getSafeImageSrc everywhere they are rendered, the Worker's HTML escaping of article title and excerpt, the cover upload's size and type gates, tag normalisation against the server pattern, and the rate-limit shapes — one upload per chosen file, one create then updates.

Verification

pnpm build, tsc -b, pnpm lint clean. 473 unit tests across 66 files and 29 Playwright tests pass. Three of the five have a test that fails on main and passes here; the other two are covered by assertions on the request the code makes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Hu1QuLxS84vdf1gmzoGtWP

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	tdn-client	2f42868	Commit Preview URL Branch Preview URL	Aug 26 2026, 02:41 AM