Decode the input before building XML commands.#57
Open
xunam wants to merge 1 commit into
Open
Conversation
|
Indeed, this seems to solve the problem for me. |
|
@xunam do you have an example of how you fixed the issue? |
Author
|
Hi, I'm not sure what you mean by "example" here, but if I remember well, I fixed the issue by patching the code as in the present PR, which has no conflict according to Github. But it seems that this repository has been unmaintained for 6 years now. Actually, I ended up writing my own Coq plugin from scratch to support later versions of Coq instead of forking coquille, because the way Coq interacts has changed completely : https://framagit.org/manu/coq-au-vim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As spotted in issue #53, Coquille chokes on non-ASCII input because of encoding problems and Python throwing
UnicodeDecodeErrorexceptions. This is a simple fix for the issue, it consists instr, we turn it into aunicodefollowing the buffer's encoding)unicodetype in command encoding.My first tests work fine but it surely deserves to be checked.