Add Enter and Escape key handlers to KeycodeModal#396
Open
joaoLouceiro wants to merge 1 commit into
Open
Conversation
…hlighted Adds keyboard event handling to the custom keycode modal so that pressing Enter confirms a valid keycode entry when the autocomplete dropdown is closed or no suggestion is highlighted. Also suppresses the global Enter/Escape handler when Downshift has already handled those keys, preventing double-firing.
Author
|
It looks like this build failed because of the issue being solved by #392. Is there any way I can help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds keyboard event handling to the KeycodeModal (custom-keycode-modal.tsx).
The feature takes into account if the Autosuggestions Combobox is open, so it doesn't interfere with it's functionality.
This means that, if the Autosuggestions Combobox is open:
fixes #395