Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few improvements to Aha's color handling:
test_print.cwhich outputs a page of formatting codes to test Aha withhighlightedflag with proper 4-bit color support, including.bg-highlightedfor independent foreground/background highlighting. Other than that I made sure to maintain CSS backward compatibility, which is why I stuck with the old.highlighted.<color>classes instead of doing separate classes for the normal and bright versions of colors.bg-red) in the tag'sstyleattribute instead of theclassattribute.--colorsparameterBecause highlighting no longer uses a CSS filter and instead is a separate color, at the moment the built-in color schemes have no normal/bright distinction. I didn't want to go ahead and decide on a color scheme since, in the end, it's your project.