Fix: tighten email regex to reduce false positives in email detection#20
Open
DivInstance wants to merge 1 commit into
Open
Fix: tighten email regex to reduce false positives in email detection#20DivInstance wants to merge 1 commit into
DivInstance wants to merge 1 commit into
Conversation
MadMena
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces false positives in email detection used across Slash by replacing the very loose
\S+@\S+with a stricter, centralized regex.Changes
EMAIL_REin api/extract.py\b[a-zA-Z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,}\bRationale
The previous pattern matched tokens with trailing punctuation or random strings containing
@, causing misclassification (e.g., treating the input as an email when it’s not). The new pattern aligns with common email formats and reduces noise.Testing
user@example.com,sub.user+tag@domain.co.uk→ detected as emailshello@world,username@,@domain.com,not-an-email.→ not detectedImpact
Improves accuracy for flows that depend on [extract.just.mail()]
Checklist
Resolves #2