feat: migrate Azure DevOps auth to OAuth 2.0 with PKCE#19
Open
thealternator89 wants to merge 2 commits intomainfrom
Open
feat: migrate Azure DevOps auth to OAuth 2.0 with PKCE#19thealternator89 wants to merge 2 commits intomainfrom
thealternator89 wants to merge 2 commits intomainfrom
Conversation
# Conflicts: # src/main/index.ts # src/main/services/azureDevOpsService.ts # src/renderer/pages/Settings.tsx
thealternator89
force-pushed
the
feature/oauth2-devops
branch
from
220ff17 to
8234801
Compare
Owner
Author
|
Note that merging this will prevent access until the Stitch application is approved in any tenant for Azure DevOps using the app (since we've removed the PAT option). Plan for merging;
Assuming it works as expected (at least the initial login works, and closing/reopening the app doesn't require a new login), we can merge it. Presumably the approval for the app registration in the tenant will persist even if the app isn't handling the token correctly, so we can fix it under this PR before merging without needing to request more assistance from the Infra team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds OAuth2.0 with PKCE for Azure DevOps integration to remove the need for PATs
Resolves #13