Updated Mapping.identity static method and test

[hanfak]

AngryDev,

Updated above as discussed during the week. Changed the tests, but needs checking, all tests are green.

Han

[codecov-io]

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #19   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      184    184           
=======================================
  Files            29     29           
  Lines           314    314           
  Branches          3      3           
=======================================
  Hits            314    314

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b2e889...ecca677. Read the comment docs.

[theangrydev]

Looks good, can you add a new unit test MappingTest that documents the intention here, something like:

• identityMappingToSameType
• identityMappingToSuperType

[theangrydev]

Oh and in case you were curious, the purpose of the test you already changed is to highlight when any changes are made to the public API so that non backwards compatible changes are not accidentally made. In this case the change is backwards compatible so updating the expected value is the right thing to do.