This repository was archived by the owner on Mar 29, 2025. It is now read-only.
Had to adjust a few bits to get the various containers to build#2
Open
adamcathersides wants to merge 1 commit into
Open
Had to adjust a few bits to get the various containers to build#2adamcathersides wants to merge 1 commit into
adamcathersides wants to merge 1 commit into
Conversation
duckfullstop
suggested changes
Feb 12, 2019
duckfullstop
left a comment
duckfullstop
left a comment
Member
There was a problem hiding this comment.
I'd prefer using .dockerignore for this instead of removing them once they're in the image. See my comment.
| COPY bundles /usr/src/app/bundles | ||
|
|
||
| # A hack to get the bower install to work. Something to do with .git files confusing it all. Meh.. https://github.com/bower/bower/issues/1492 | ||
| RUN cd /usr/src/app/bundles/thebiggame && rm .git .gitignore .gitattributes |
Member
There was a problem hiding this comment.
I personally think this should be handled with a .dockerignore file, for two reasons: first, it means these files don't end up in the image at all, saving layer size; and second, it doesn't require an extra RUN layer.
Documentation on .dockerignore here: https://docs.docker.com/engine/reference/builder/#dockerignore-file
Contributor
Author
There was a problem hiding this comment.
Yeah good idea, i'll get on it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a bit more info to the readme and also had to get rid of the
.gitfiles so the the bower stuff can install. It seems to build now..