Skip to content

fix: log info message instead of failing execution#3

Merged
thebinaryfelix merged 3 commits into
thebinaryfelix:mainfrom
awjans:issue-002
Sep 15, 2025
Merged

fix: log info message instead of failing execution#3
thebinaryfelix merged 3 commits into
thebinaryfelix:mainfrom
awjans:issue-002

Conversation

@awjans

@awjans awjans commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

🛠 What was done

Closes #2

modified line 8 of src/utils/setFinalOutput/setFinalOutput.ts

From:
failExecution(message)
To:
logInfo(message)

updated src/utils/setFinalOutput/setFinalOutput.test.ts accordingly.

Bumped the following Dependencies to resolve vulnerabilities:
"@release-it/bumper": "^7.0.5",
"news-fragments": "^4.0.0",

🧪 How to test

npm run test

@thebinaryfelix

Copy link
Copy Markdown
Owner

@awjans Thank you for the contribution! I had no idea that this repository was being used actively by other people. Just saw the open issue now.

Regarding this PR, could you update Node to the latest LTS please? The CI is complaining about it.

@thebinaryfelix thebinaryfelix changed the title fix: log info message instead of failing execution when files are mis… fix: log info message instead of failing execution Sep 15, 2025
@thebinaryfelix thebinaryfelix added the bug Something isn't working label Sep 15, 2025
@awjans

awjans commented Sep 15, 2025

Copy link
Copy Markdown
Contributor Author

I'm not sure of yarn.lock should be checked in from my version. That might fix the warning. I did bump the node versions in the workflows.

@thebinaryfelix
thebinaryfelix merged commit 5e761d0 into thebinaryfelix:main Sep 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Missing files causes job to fail, not return false as indicated

2 participants