Repository navigation
feat: display keybindings in modal - #17
Merged
Merged
Conversation
…truct field names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new modal model that renders all application keybindings in a scrollable view using
bubbles/helpandbubbles/viewport.Changes
bubbles/viewport.Cancel(Esc) keybinding to close active modals (used for both password and keybinding modals).?hotkey and event handlers to open/close the modal from the root model.Keybindingsand aToBubblesBatchhelper for converting a slice ofBindingtobubbles/key.Binding.wifiGroupinto separate Saved and Available groups for clearer visual organization.tableGroupto represent generic navigation across UI models, and renamed it tonavGroup.KeybindsModalTheme.Result
Pressing
?anywhere (unless another modal is focused/active - i.e., error or password modal) in the app displays anviewportlisting all keyboard shortcuts categorized by domain, allowing users to easily discover available keybindings.