fix(config): honor the legacy WORKSPACES_DIR setting - #21
thecodacus wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe workspace root now reads ChangesWorkspace root fallback
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The change supports the legacy setting without disrupting the preferred setting or default workspace path. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Native installs that set only WORKSPACES_DIR silently listed /workspaces because both sides of the fallback read WORKSPACE_ROOT. Restore the legacy variable fallback and correct its comment.
Verified the current source expression with a legacy-only environment, both variables set (WORKSPACE_ROOT wins), and neither set (/workspaces).
Fixes #5.
Documentation: explains native workspace-variable precedence and the distinction between Compose host paths and container paths.