Skip to content

fix(config): honor the legacy WORKSPACES_DIR setting - #21

Open
thecodacus wants to merge 2 commits into
mainfrom
fix/issue-5-workspace-env
Open

thecodacus wants to merge 2 commits into
mainfrom
fix/issue-5-workspace-env

Conversation

@thecodacus

@thecodacus thecodacus commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Native installs that set only WORKSPACES_DIR silently listed /workspaces because both sides of the fallback read WORKSPACE_ROOT. Restore the legacy variable fallback and correct its comment.

Verified the current source expression with a legacy-only environment, both variables set (WORKSPACE_ROOT wins), and neither set (/workspaces).

Fixes #5.

Documentation: explains native workspace-variable precedence and the distinction between Compose host paths and container paths.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d0d15498-9881-42fa-b5e0-182d37778c63

📥 Commits

Reviewing files that changed from the base of the PR and between 0dcb312 and 3a57427.

📒 Files selected for processing (1)
  • server/src/index.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The workspace root now reads WORKSPACE_ROOT, then the legacy WORKSPACES_DIR, and finally defaults to /workspaces. The related comment now identifies WORKSPACES_DIR as the legacy variable.

Changes

Workspace root fallback

Layer / File(s) Summary
Workspace root resolution
server/src/index.ts
The fallback now reads WORKSPACES_DIR instead of repeating WORKSPACE_ROOT. The comment was updated to match.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 3a574

The change supports the legacy setting without disrupting the preferred setting or default workspace path.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The change satisfies issue #5. server/src/index.ts now resolves WORKSPACE_ROOT first, then WORKSPACES_DIR, then /workspaces. This preserves preferred-variable precedence, supports legacy-only …
Out of Scope Changes check ✅ Passed The reviewed change is limited to the workspace directory fallback and its related comment in server/src/index.ts. These changes directly support issue #5. No unrelated implementation or documentati…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: support for the legacy WORKSPACES_DIR configuration setting.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-5-workspace-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WORKSPACES_DIR is read by nothing — the || fallback names WORKSPACE_ROOT twice

1 participant