fix(web): make navigation and composing usable on phones - #25
Open
thecodacus wants to merge 2 commits into
Open
thecodacus wants to merge 2 commits into
thecodacus wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Send button reported in #3 already exists on main, but the sidebar still consumes phone width, the root uses 100vh, and the slash picker has no scrolling boundary.
Below md, navigation now opens in a drawer with explicit close/backdrop controls and expands independently of the saved desktop collapse preference. The page uses the dynamic viewport height with shrinking flex containers. The phone composer uses 16px text, and slash commands have a bounded scrolling menu with touch-friendly click selection.
Validation: production server/web build; Playwright on Chrome at 375×812 and 375×500 verifies sending, drawer controls, workspace access, no horizontal/vertical body overflow, font size, and internal command scrolling. Inspected the resulting screenshot. Native iOS Safari was not available for a device test.
Fixes #3.
Documentation: adds phone navigation, sending, and slash-command scrolling instructions.