fix(executor): make session mounts writable by the runner - #27
Open
thecodacus wants to merge 1 commit into
Open
thecodacus wants to merge 1 commit into
thecodacus wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A runner image's non-root USER cannot write a root-owned session bind mount. Reproduced this on Cortex with a disposable CPU-only container: UID 1000 failed with EACCES against a new root-owned directory; UID 0 wrote successfully.
Create the session directory as the portal user before Docker starts, check it is writable, and pass that user's numeric UID:GID to the runner. This is root only when the portal itself is root. Preserve --rm, capability dropping, and no-new-privileges; document custom-image and existing-directory ownership requirements.
Validation: server build; fake-Docker launch regression checks directory ownership/mode and actual launch arguments; the disposable-container permission reproduction above. No production container was changed.
Fixes #16. The separate mount-namespace correction is PR #26; both are relevant when the portal runs in Docker.