Add support for Grafik Eye QS keypad#44
Open
kevineriklee wants to merge 4 commits into
Open
Conversation
thecynic
reviewed
Nov 27, 2019
thecynic
left a comment
Owner
There was a problem hiding this comment.
small nit, but otherwise looks good.
thecynic
reviewed
May 2, 2020
thecynic
left a comment
Owner
There was a problem hiding this comment.
Feel free to reupload, I haven't heard back since last time i commented.
Author
|
Sorry life got busy and I didn't get a chance to look at this for a while... Addressed your comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this with the Grafik Eye QS attached to my RadioRA2 main repeater and it appears to work.
A few design decisions that are worth discussing: