support for Homeworks QS connection#95
Open
rzulian wants to merge 2 commits into
Open
Conversation
cdheiser
reviewed
May 27, 2024
| self._lock = threading.Lock() | ||
| self._connect_cond = threading.Condition(lock=self._lock) | ||
| self._recv_cb = recv_callback | ||
| self._controller = Controller.UNKNOWN |
Collaborator
There was a problem hiding this comment.
What's the value of noting this? Just in case we encounter a scenario where we need to know?
Maybe at least add a property for retrieving this.
cdheiser
reviewed
Jun 16, 2025
| USER_PROMPT = b'login: ' | ||
| PW_PROMPT = b'password: ' | ||
| PROMPT = b'GNET> ' | ||
| PROMPT = b'> ' |
Collaborator
There was a problem hiding this comment.
Why not make this b'NET> ' which would work with HW and RA2?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the ability to connect to a Homeworks QS processor