Introduction of "bvpp" tag - Battery and/or voltage are primary properties - #705
Merged
Conversation
jcsanyi
added a commit
to jcsanyi/theengs-gateway
that referenced
this pull request
Aug 14, 2026
The tag from theengs/decoder#705 is metadata rather than a reading, so it follows "track": kept for discovery, dropped from the published copy. ADVANCED_DATA won't work, as it's stripped before discovery runs.
3 tasks
jcsanyi
added a commit
to jcsanyi/theengs-gateway
that referenced
this pull request
Aug 15, 2026
The tag from theengs/decoder#705 is metadata rather than a reading, so it follows "track": kept for discovery, dropped from the published copy. ADVANCED_DATA won't work, as it's stripped before discovery runs.
1technophile
pushed a commit
to theengs/gateway
that referenced
this pull request
Aug 16, 2026
* Remove "bvpp" from the published payload when publish_advdata is 0 The tag from theengs/decoder#705 is metadata rather than a reading, so it follows "track": kept for discovery, dropped from the published copy. ADVANCED_DATA won't work, as it's stripped before discovery runs. * Publish entity_category for diagnostic properties Battery, voltage, packet counters and transmit power describe the device rather than what it measures, and should properly be marked as diagnostic in HA. Battery and voltage are left alone on devices where those are the primary purpose - based on the "bvpp" decoder flag. Both lists also cover the various aliases each property has in the library. * Add a configuration option for diagnostic categorization Defaults to 0, so nothing changes until it is enabled. * [DOCS] Diagnostic entity categorization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist: