[CI] Upgrade build tooling to fix the Python 3.8 package build - #327
Merged
Conversation
setuptools is installed unpinned, so pip leaves whatever the runner image ships in place. The Python 3.8 image ships setuptools 56.0.0, which current setuptools_scm fails against when building the sdist: AttributeError: ignore_egg_info_in_manifest. Adding --upgrade installs the newest setuptools each Python version supports, which is 75.3.4 on 3.8.
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
test (3.8)fails on every pull request against this repo, in theBuild packagestep, withAttributeError: ignore_egg_info_in_manifest.Install requirementsinstalls setuptools unpinned, so pip leaves whatever the runner image ships in place. The 3.8 image ships setuptools 56.0.0, from 2021, which currentsetuptools_scmfails against. The other matrix entries pass only because their images happen to ship something more recent. Adding--upgradeinstalls the newest setuptools each Python version supports, which is 75.3.4 on 3.8.Tested on a pull request against my own fork: a commit changing nothing but a comment in the workflow reproduced the failure (run), and the
--upgradechange turned it 6/6 green (run).setuptools_scmwas 10.2.1 in both, so setuptools is the only thing that moved.Worth knowing separately: before today's failure on #325, this workflow had effectively not run since 2026-06-07 - every pull request after that sat behind the approval gate for outside contributors.
Checklist: