chore: drop manual markdown prettier override now in shared config - #215
Merged
Conversation
The library preset outputs index.mjs and index.d.mts but exports referenced index.js and index.d.ts which don't exist. TypeScript with moduleResolution: "bundler" strictly follows the exports map and fails when the referenced files are missing. Signed-off-by: Newton <vj2kp2hfh4@privaterelay.appleid.com> Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
@theholocron/prettier-config@7.17.0 includes the *.md useTabs:false override directly. Removed the manual overrides block (configs#352). Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 22 22
Lines 234 234
Branches 57 57
=======================================
Hits 228 228
Partials 6 6 🚀 New features to boost your workflow:
|
All configs packages released together at 7.17.0. Update catalog specifiers and lockfile to match — per lockstep policy. Signed-off-by: Newton <5769156+iamnewton@users.noreply.github.com>
Contributor
Author
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.mdoverride block fromprettier.config.ts@theholocron/prettier-configto7.17.0in the lockfileWhy
@theholocron/prettier-config@7.17.0now includes the*.md/*.mdxuseTabs: false, tabWidth: 2override directly (theholocron/configs#352). No need to repeat it in every repo.Test plan