Skip to content

Fix show-more being displayed over chat messages#99

Closed
nomadturk wants to merge 14 commits intothelounge:masterfrom
nomadturk:master
Closed

Fix show-more being displayed over chat messages#99
nomadturk wants to merge 14 commits intothelounge:masterfrom
nomadturk:master

Conversation

@nomadturk
Copy link

As per erming/shout#568:

With this PR I tried fixing #366 by changing it's position to relative.
It wasn't a pretty sight to see "Show more" bar on existing chat
messages.

With this fix Show More button no more will overlap with the underneath
text.
As in:

chrome_2016-02-22_16-43-50

Result will be like:
Test image

This fix also includes @xPaw 's contribution as well.
PS: I mistakenly added another commit to this PR and removed it later.
See #88 for the next one.

As per erming/shout#568:

With this PR I tried fixing #366 by changing it's position to relative.
It wasn't a pretty sight to see "Show more" bar on existing chat
messages.

With this fix Show More button no more will overlap with the underneath
text.
As in:

![chrome_2016-02-22_16-43-50](https://cloud.githubusercontent.com/assets/10355660/13222386/6e609994-d988-11e5-9568-b2cb97fe4137.png)

Result will be like:
![Test
image](https://cloud.githubusercontent.com/assets/10355660/12207394/0d0ff402-b64f-11e5-9e9d-28108b518998.png)

This fix also includes @xPaw 's contribution as well.
PS: I mistakenly added another commit to this PR and removed it later.
See #88 for the next one.
@xPaw
Copy link
Member

xPaw commented Feb 24, 2016

You've re-created the PR, but missed the discussion. Your fix should work as well if you remove position completely.

Also you forgot to move over the changes that remove the no longer necessary padding and margins.

@astorije
Copy link
Member

Linking to #87 for discussion purposes.

@astorije
Copy link
Member

@xPaw, do you want to take ownership of this one?

@nomadturk
Copy link
Author

My bad, I totally forgot it after trying to rebase a few times. ^^

Removed padding related css entries as well.

@xPaw
Copy link
Member

xPaw commented Feb 25, 2016

So you've created a new PR over the last one, but it includes exact same changes. Have you tested by removing position declaration completely?

@nomadturk
Copy link
Author

Yes,

Over chrome, the results were the same with position removed as well. But I didn't have chance to test it on different browsers other than Chrome and Firefox.

Well, not exactly the same. The last PR had some extra commits I included by mistake so I had to cancel that one. That's the reason I opened a new one, due to my incompetency (:

About position do you want it gone or just changed to relative?
The results won't differ much to my eyes.

@xPaw
Copy link
Member

xPaw commented Feb 26, 2016

Removing it should be fine.

And you don't need to make a new PR to fix your mistakes, check this out http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Feb 26, 2016
nomadturk and others added 12 commits February 26, 2016 13:04
As per erming/shout#568:

With this PR I tried fixing #366 by changing it's position to relative.
It wasn't a pretty sight to see "Show more" bar on existing chat
messages.

With this fix Show More button no more will overlap with the underneath
text.
As in:

![chrome_2016-02-22_16-43-50](https://cloud.githubusercontent.com/assets/10355660/13222386/6e609994-d988-11e5-9568-b2cb97fe4137.png)

Result will be like:
![Test
image](https://cloud.githubusercontent.com/assets/10355660/12207394/0d0ff402-b64f-11e5-9e9d-28108b518998.png)

This fix also includes @xPaw 's contribution as well.
PS: I mistakenly added another commit to this PR and removed it later.
See #88 for the next one.

Removed padding related css entries for show-more
As per erming/shout#568:

With this PR I tried fixing #366 by changing it's position to relative.
It wasn't a pretty sight to see "Show more" bar on existing chat
messages.

With this fix Show More button no more will overlap with the underneath
text.
As in:

![chrome_2016-02-22_16-43-50](https://cloud.githubusercontent.com/assets/10355660/13222386/6e609994-d988-11e5-9568-b2cb97fe4137.png)

Result will be like:
![Test
image](https://cloud.githubusercontent.com/assets/10355660/12207394/0d0ff402-b64f-11e5-9e9d-28108b518998.png)

This fix also includes @xPaw 's contribution as well.
PS: I mistakenly added another commit to this PR and removed it later.
See #88 for the next one.

Removed padding related css entries for show-more

Removed reference to position
# Conflicts:
#	client/css/style.css
# The first commit's message is:

Fix show-more being displayed over chat messages

As per erming/shout#568:

With this PR I tried fixing #366 by changing it's position to relative.
It wasn't a pretty sight to see "Show more" bar on existing chat
messages.

With this fix Show More button no more will overlap with the underneath
text.
As in:

![chrome_2016-02-22_16-43-50](https://cloud.githubusercontent.com/assets/10355660/13222386/6e609994-d988-11e5-9568-b2cb97fe4137.png)

Result will be like:
![Test
image](https://cloud.githubusercontent.com/assets/10355660/12207394/0d0ff402-b64f-11e5-9e9d-28108b518998.png)

This fix also includes @xPaw 's contribution as well.
PS: I mistakenly added another commit to this PR and removed it later.
See #88 for the next one.

Removed padding related css entries for show-more

Removed reference to position

# The 2nd commit message will be skipped:

#	Removed padding related css entries for show-more
As per erming/shout#568:

With this PR I tried fixing #366 by changing it's position to relative.
It wasn't a pretty sight to see "Show more" bar on existing chat
messages.

With this fix Show More button no more will overlap with the underneath
text.
As in:

![chrome_2016-02-22_16-43-50](https://cloud.githubusercontent.com/assets/10355660/13222386/6e609994-d988-11e5-9568-b2cb97fe4137.png)

Result will be like:
![Test
image](https://cloud.githubusercontent.com/assets/10355660/12207394/0d0ff402-b64f-11e5-9e9d-28108b518998.png)

This fix also includes @xPaw 's contribution as well.
PS: I mistakenly added another commit to this PR and removed it later.
See #88 for the next one.

Removed padding related css entries for show-more

Removed reference to position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants