Extended ps_ssfx_gloss_minmax for "Glossy Puddles" addon - #659
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Glossy Puddles addon uses shader_param_5 to change reflectivity of the puddles. Many addons shares the same shader_param_N constants, and that can lead into compability issues.
So, I decided to reuse ps_ssfx_gloss_minmax. Originally, it was an FVec3, so I changed it to FVec4 in order to store an additional value for Glossy Puddles addon.
Note:
This requires the author to swap shader_param_5.w for ssfx_gloss.w in the terrain shaders.
Variable has min value of 0.0 and max of 1.0 - which should be sufficient.