scripted attachments: lights and 3d ui on attachments, a shader parameter per mesh child, wider debug lines (linked PR #2) - #675
Open
TheLostInPlace wants to merge 8 commits into
Conversation
themrdemonized
marked this pull request as draft
September 18, 2026 04:40
TheLostInPlace
marked this pull request as ready for review
September 18, 2026 04:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINKED PR # 2
This PR was split into a 4 part PR due to the size and to aid in reviewing changes
Changes
Additions to the script attachment manager and the renderer behind it.
picks, and find it again later
can drive shader effects on each of its parts (we use it for the watch tubes)
No change for anything that does not use the new calls. Every new export is listed in
lua_help_ex.script. Built DX11-AVX x64, tested in game. Merges into the MT branch withoutconflicts, but there
render_hud_attachments_alwayshas to take the dsgraph manager likerender_huddoes. The MT PR has that.