map and ui: map spot callbacks, a bulk spot read, a few window additions and a minimap widget for scripts (linked PR # 3) - #676
Open
TheLostInPlace wants to merge 11 commits into
Conversation
spots, pointers, overrides and the screen shader for a device page
underlay, per type height icons and pointer art, and an icon shader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINKED PR # 3
This PR was split into a 4 part PR due to the size and to aid in reviewing changes
Changes
The map and ui pieces a script needs to show the level map on a screen held in the hand.
on_map_location_addedandon_map_location_removed, with the spot type and theobject id (removals are collected on the map update thread and sent from the main thread), and a
read of all spots with their current type in one call
class, the size of a texture, and the minimap icon a spot type declares
CUIStaticcan be laid along the line between two points and tells where its heading pivotis, windows get a hide lock, mouse capture and clip rects
CUIMiniMapWidget, a minimap window a script creates and puts inside any other window. It hasits own spot pool, quest pointers are on only for the spot types the script asks for, the one
followed target is the only spot searched from another level and that path is cached, and every
texture and the spot shader can be replaced from script
The pda map and the hud minimap are untouched, apart from the cached path in
CMapLocation::UpdateSpot, which only saves a path search per frame. Every new export is listed inlua_help_ex.script. Built DX11-AVX x64, tested in game Wearable Devices mod. On the MT branchUpdateSpotconflicts with a null check that lives there, the MT PR resolves it.