Skip to content

Fix signed char indexing in lexer punctuation table #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobmoser76 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix signed char indexing in lexer punctuation table #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/idlib/Lexer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,15 +547,15 @@ void idLexer::CreatePunctuationTable( const punctuation_t *punctuations ) {
newp = &punctuations[i];
lastp = -1;
//sort the punctuations in this table entry on length (longer punctuations first)
for (n = idLexer::punctuationtable[(unsigned int) newp->p[0]]; n >= 0; n = idLexer::nextpunctuation[n] ) {
for (n = idLexer::punctuationtable[(unsigned char) newp->p[0]]; n >= 0; n = idLexer::nextpunctuation[n] ) {
p = &punctuations[n];
if (strlen(p->p) < strlen(newp->p)) {
idLexer::nextpunctuation[i] = n;
if (lastp >= 0) {
idLexer::nextpunctuation[lastp] = i;
}
else {
idLexer::punctuationtable[(unsigned int) newp->p[0]] = i;
idLexer::punctuationtable[(unsigned char) newp->p[0]] = i;
}
break;
}
Expand All @@ -567,7 +567,7 @@ void idLexer::CreatePunctuationTable( const punctuation_t *punctuations ) {
idLexer::nextpunctuation[lastp] = i;
}
else {
idLexer::punctuationtable[(unsigned int) newp->p[0]] = i;
idLexer::punctuationtable[(unsigned char) newp->p[0]] = i;
}
}
}
Expand Down