Fix liquid combat and movement behavior - #6
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d06a09d551
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // openQ4 BEGIN | ||
| savefile->WriteInt( (int)previousWaterLevel ); | ||
| savefile->WriteInt( previousWaterType ); | ||
| savefile->WriteInt( nextLiquidSurfaceSoundTime ); |
There was a problem hiding this comment.
Existing saves from the parent build are stamped as compatibility version 3, which remains the current accepted version, but they do not contain this new integer. Restore() now unconditionally consumes four bytes for it, shifting every subsequent player field and ultimately causing synchronization/footer validation to reject the save. Either keep this transient debounce timer out of serialization or introduce a new compatibility version with a gated migration; the mirrored MP serializer has the same layout change.
AGENTS.md reference: AGENTS.md:L22-L22
Useful? React with 👍 / 👎.
1 participant
Companion game-module changes required by openQ4 pull request #118. Adds liquid projectile and hitscan traversal, reliable splash audio, bubble trails, water-jump egress, surface-sound debounce, underwater acoustics, and localized environmental death routing in matching SP and MP code paths.\n\nValidated locally with a clean x64 SP/MP module build and the parent openQ4 PR validation suite.