Initialize engine-side TriSurf allocators (#108) - #111
Merged
Conversation
The renderer module and built-in dmap compiler have separate copies of the render-geometry static library. Initialize the engine copy for tools, make the lifecycle idempotent across static-renderer builds, and release it during common shutdown. Fixes #108
Initialize the engine/tool render-geometry copy after renderer data setup but before startup scripts can invoke dmap. Static-renderer builds now preserve matched allocation accounting while module builds retain an independent initialized tool copy. Refs #108
themuffinator
force-pushed
the
codex/issue-108-dmap-trisurf-lifecycle
branch
from
August 15, 2026 10:45
6aca8ea to
9f6cce0
Compare
Owner
Author
|
Final hosted validation for 9f6cce0: 21 checks passed, 4 failed, 0 pending. Commit Validation and ARM64 Cross Build passed completely, including Windows/Linux builds, ASan/UBSan, all four macOS thin builds, and both universal2 assembly/package/dedicated-smoke jobs. The four red macOS Push Verification jobs exactly reproduce main baseline renderer-default-safety diagnostics and contain no TriSurf allocator or lifecycle failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The v0.10 crash dump was symbolized against the exact shipped engine PDB.
dmap game/airdefense1.mapcrashed inidDynamicBlockAlloc<idDrawVert>::AllocInternal()while deriving a light polytope. After renderers became runtime modules,openq4_render_geois linked once into the client and independently into each renderer. Renderer startup initialized only the renderer module's file-static allocator copy; built-indmapused the client copy, which remained uninitialized.Validation
python tools/tests/dmap_render_geometry_lifecycle.pypython tools/tests/renderer_vulkan_md5r_compatibility.pydmap -noCM -noAAS game/airdefense1completed in 3 seconds, reported the stock map leak normally, and shut down cleanly without an allocator or lifecycle errorFixes #108