fix(api): serialize Codex thread settings in config (JAM-232) - #6
Draft
darvell-thenvoi wants to merge 2 commits into
Draft
fix(api): serialize Codex thread settings in config (JAM-232)#6darvell-thenvoi wants to merge 2 commits into
darvell-thenvoi wants to merge 2 commits into
Conversation
Co-authored-by: Darvell <contact@darvell.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://linear.app/thenvoi/issue/JAM-232/correct-codex-threadturn-serialization-for-reasoning-effort-and-web
Codex 0.148 reads thread reasoning and web-search defaults from
thread/startandthread/resumeconfig. The SDK instead emitted top-level effort and legacy search extras, inherited thread effort intoturn/start, and sent unsupported per-turnmodelProvider.This branch first reapplies the previously reviewed native terminal-status patch after the latest fork replay, then corrects request ownership:
config.model_reasoning_effortandconfig.web_search.Review focus: exact Codex 0.148 field ownership, typed-versus-generic config precedence, and source compatibility for removed per-turn setters.
Verification:
cargo fmt --all --checkpassed.jam-owned-stdio-latest.Jam's dependency pin and real owned-Codex start/resume/web-search journey remain in thenvoi/tjam and are not claimed by this dependency pull request.