Collect & Provide enhanced packets through the API#475
Open
TheDaChicken wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Another idea for this PR is to instead: deprecate the old data field and switch to single array of structs that can point to data, size and flags. This could be helpful when more streams get added because it wouldn't require much changes. The downside is deprecating another field. The HD spec does reserve another two streams. In my opinion, the possibility of those two other streams to be used is small. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnrsc5 used to report HDC enhanced packets before elastic-buffer changes. The enhacned packets weren't aligned together because the elastic-buffer didn't exist. This is meant to align them via elastic buffer and collects the enhanced packets to bring them together with the HDC core stream.
100% looking for feedback. I am not sure if enhanced packets should be part of bitrate calculation etc. I do print another log message for mismatches in for enhanced packets.
This is where maybe an flag needs to be added to say the enhanced stream isn't being decoded? That way, clients can ignore this for bitrate?