fix(harness-letratag): derive diagnostic width from engine headDots#2
Merged
Conversation
`LetraTagMedia.printableDots` was removed from letratag-core as a redundant field (it duplicated the engine's `headDots`). Read the 30-dot printable width off `engine.headDots` instead of the media descriptor. Works against both the published pin and the local link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apps/harness-letratag/src/diagnostic-print.tsreadinput.media.printableDots, which is removed fromletratag-core(thermal-label/letratag#2 — it was a redundant field duplicating the engine'sheadDots).Derive the 30-dot printable width from
engine.headDotsinstead of the media descriptor. Compiles against both the published^0.6.0pin and a locallink:to the letratag working tree;pnpm -F harness-letratag typecheckis green.No behavioural change —
printableDotswas always30 === headDotson the single-width LT-200B, soMath.min(printableDots, headDots)already resolved toheadDots.