Optimize extraction functions and improve semantic clarity in can? #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes two improvements to the indexed implementation:
1. Performance optimization: Replace destructuring with direct nth access
- extract-resource-id-from-rel-tuple-datom now uses nth for speed
- extract-subject-id-from-reverse-rel-tuple-datom now uses nth for speed
- Added docstrings documenting tuple formats for clarity
2. Semantic clarity: Use correct extraction function for reverse lookups
- can? function now uses extract-subject-id-from-reverse-rel-tuple-datom
for reverse index lookups (lines 258 and 275)
- While both functions extract from position 4, using the semantically
correct function makes the code intent clearer and more maintainable
Note: Both tuple formats have the desired eid at position 4, so this
change improves code clarity without fixing an actual bug.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
theronic
commented
Nov 13, 2025
| reverse-end [resource-type resource-eid via-relation intermediate-type Long/MAX_VALUE] | ||
| intermediates (->> (d/index-range db reverse-tuple-attr reverse-start reverse-end) | ||
| (map extract-resource-id-from-rel-tuple-datom))] ; Extract subject (intermediate) eid | ||
| (map extract-subject-id-from-reverse-rel-tuple-datom))] ; Extract subject (intermediate) eid |
Owner
Author
There was a problem hiding this comment.
this was incidentally correct before (just made it explicit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes two improvements to the indexed implementation:
Performance optimization: Replace destructuring with direct nth access
Semantic clarity: Use correct extraction function for reverse lookups
Note: Both tuple formats have the desired eid at position 4, so this change improves code clarity without fixing an actual bug.
🤖 Generated with Claude Code