Skip to content

Simplify ping pong handler #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kafkiansky merged 2 commits into from
Mar 17, 2026
Merged

Simplify ping pong handler #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca1946
Simplify ping pong handler
kafkiansky Mar 17, 2026
8272b00
chore: fix cs
kafkiansky Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/Internal/Connection/PingPongHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace Thesis\Nats\Internal\Connection;

use Amp;
use Revolt\EventLoop;
use Thesis\Nats\Internal\Protocol;

Expand All @@ -18,8 +17,6 @@ final class PingPongHandler
/** @var non-negative-int */
private int $pings = 0;

private ?float $lastPingPongTime = null;

public function __construct(
private readonly Connection $connection,
) {}
Expand All @@ -32,23 +29,22 @@ public function startup(int $interval, int $maxPings): void
{
$interval /= 1_000;

$this->callbackId = EventLoop::repeat($interval, function () use ($interval, $maxPings): void {
$this->callbackId = EventLoop::repeat($interval, function () use ($maxPings): void {
if (++$this->pings > $maxPings) {
$this->forceStop();
} elseif ((Amp\now() - (int) $this->lastPingPongTime) > $interval) {
$this->lastPingPongTime = Amp\now();
$this->connection->execute(Protocol\Ping::Frame);

return;
}

$this->connection->execute(Protocol\Ping::Frame);
});

$this->connection->hooks()->onPing(function (): void {
$this->lastPingPongTime = Amp\now();
$this->connection->execute(Protocol\Pong::Frame);
});

$this->connection->hooks()->onPong(function (): void {
$this->lastPingPongTime = Amp\now();
$this->pings = max(0, $this->pings - 1);
$this->pings = 0;
});

$this->connection->hooks()->onClose($this->stop(...));
Expand Down