enable bubbling of the events scrollSpy:enter and scrollSpy:exit#10
Open
Mithgol wants to merge 2 commits into
Open
enable bubbling of the events scrollSpy:enter and scrollSpy:exit#10Mithgol wants to merge 2 commits into
scrollSpy:enter and scrollSpy:exit#10Mithgol wants to merge 2 commits into
Conversation
Mithgol
added a commit
to Mithgol/phido
that referenced
this pull request
Jul 17, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the events triggered by ScrollSpy do not bubble because they are triggered by the jQuery's
.triggerHandlermethod which (according to the docs) is similar to.trigger()but one of the exceptions is the following:Unfortunately, for me it's an issue. Sometimes in my applications (PhiDo, for example) I have to initiate scrollspying on hundreds of elements. Installing a separate event handler on each of these elements (instead of only one handler on a parent element) seems superfluous.
Hence a pull request to replace
.triggerHandlerwith a simple.trigger.(Also fixes #8 because is based on its code branch.)