Add missing .lycheecache entries for links merged without cache updates - #186
Merged
chalin merged 3 commits intoAug 17, 2026
Merged
Conversation
PRs theupdateframework#130 and theupdateframework#175 added or changed external links without updating the committed .lycheecache, so the cache-coverage guard on main (git diff --exit-code .lycheecache) has been failing since. Regenerated and normalized the cache; warm-run byte-stable.
Local runs of npm test previously passed even when check:links had regenerated a .lycheecache that differed from the committed one; only CI's post-run git diff step caught it. Chain the same guard into test via _diff:check:link-cache so the drift is visible pre-push. The check stays out of check:links itself so Netlify's warn-only postbuild path keeps deploys unblocked.
Match the check:format help idiom. From PR review feedback.
Collaborator
Author
|
@JustinCappos, TLDR:
The Links check is now required, so it must be green, and the branch current with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
git diff --exit-code .lycheecacheguard in the Links workflow has failed on everymainrun since it landed, while the link check itself passes: 08-04 (on #161's own merge commit), 08-08, 08-13.Cause: three URLs are checked but missing from the committed
.lycheecache:main;Fix:
npm run check:linksand committed the normalized result (3 added entries, nothing else). Verified that a repeat run leaves the file unchanged, so the guard goes green.npm test(_diff:check:link-cache), so cache drift is visible locally before pushing instead of CI-only. It stays out ofcheck:linksitself so Netlify's warn-only postbuild path keeps deploys unblocked.Beyond this PR:
mainhad no required status checks, so Fix typo: Uodates -> Updates in news.md #167 and Fix broken Bottlerocket adoption link #175 merged over a red Links check.BUILD and CHECK LINKSis required and strict onmain; red blocks merge, stale branches must update first.