Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions database_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ def get_metrics():
""",
((today - timedelta(days=days - 1)).strftime("%Y-%m-%d"),),
)
user_counts = dict(user_rows)
# PostgreSQL returns DATE values as datetime.date objects, while SQLite
# returns strings. Normalize both so they match the string chart labels.
user_counts = {str(day): count for day, count in user_rows}
metrics["users_per_day"] = [user_counts.get(date, 0) for date in date_labels]

# Comparisons created per day
Expand All @@ -56,7 +58,7 @@ def get_metrics():
""",
((today - timedelta(days=days - 1)).strftime("%Y-%m-%d"),),
)
comp_counts = dict(comp_rows)
comp_counts = {str(day): count for day, count in comp_rows}
metrics["comparisons_per_day"] = [comp_counts.get(date, 0) for date in date_labels]

# Images uploaded per day (by image_positions join comparisons for date)
Expand All @@ -70,7 +72,7 @@ def get_metrics():
""",
((today - timedelta(days=days - 1)).strftime("%Y-%m-%d"),),
)
img_counts = dict(img_rows)
img_counts = {str(day): count for day, count in img_rows}
metrics["images_per_day"] = [img_counts.get(date, 0) for date in date_labels]

metrics["date_labels"] = date_labels
Expand Down
2 changes: 1 addition & 1 deletion templates/metrics.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
</div>
</div>
</div>
<script src="https://cdn.jsdelivr.net/npm/chart.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/4.5.1/chart.min.js"></script>
<script>
// Use Jinja tojson filter for safe JS injection
const dateLabels = {{ metrics.date_labels | tojson }};
Expand Down
16 changes: 16 additions & 0 deletions tests/test_metrics.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from datetime import date

import database
import database_metrics

Expand Down Expand Up @@ -32,6 +34,20 @@ def test_metrics_report_database_and_local_storage(isolated_db, tmp_path, monkey
assert len(metrics["comparisons_per_day"]) == 14


def test_metrics_daily_counts_match_date_objects(isolated_db, monkeypatch):
today = date.today()
daily_results = iter([[(today, 2)], [(today, 3)], [(today, 4)]])
monkeypatch.setattr(database_metrics, "query", lambda *_args: next(daily_results))
monkeypatch.setattr(database_metrics, "is_s3_enabled", lambda: False)

metrics = database_metrics.get_metrics()

today_index = metrics["date_labels"].index(today.isoformat())
assert metrics["users_per_day"][today_index] == 2
assert metrics["comparisons_per_day"][today_index] == 3
assert metrics["images_per_day"][today_index] == 4


def test_metrics_sum_s3_metadata_sizes(isolated_db, monkeypatch):
comparison_id = "77777777-7777-7777-7777-777777777777"
database.create_comparison(comparison_id, "S3", None, [], {}, None)
Expand Down
Loading