Skip to content

feat: add time into the telemetry payload#47

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
zhongys-c8y:always-add-time
Oct 27, 2025
Merged

feat: add time into the telemetry payload#47
reubenmiller merged 1 commit intothin-edge:mainfrom
zhongys-c8y:always-add-time

Conversation

@zhongys-c8y
Copy link
Contributor

@zhongys-c8y zhongys-c8y commented Oct 24, 2025

Another option to add time is to always add a time fragment into the telemetry payloads.
This is the alternative option for this PR: #46

@github-actions
Copy link

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
22 0 0 22 100 44.691024999s

Passed Tests

Name ⏱️ Duration Suite
Device should support the operation c8y_ModbusConfiguration 0.183 s Device
Set values via c8y_ModbusConfiguration Operation 2.570 s Operation
Poll rate and transmit rate should be updated for the Device 0.406 s Operation
Poll rate and transmit rate should be updated on the Device 2.572 s Operation
Device should support the operation c8y_ModbusDevice 0.182 s Device
Device should support the operation c8y_SerialConfiguration 0.259 s Device
Set values via c8y_SerialConfiguration Operation 2.560 s Operation
Serial configuration should be updated for the Device 0.346 s Operation
Serial configuration should be updated on the Device 2.564 s Operation
Device should have installed software tedge-modbus-plugin 0.206 s Debian
Service should be active 2.561 s Debian
ReInstall Modbus Plugin 22.446 s Debian
Device should have the fragment c8y_ModbusConfiguration 0.363 s Device
ChildDevice TestCase1 should be created 0.357 s Device
ChildDevice TestCase1 should have the fragment c8y_ModbusDevice 0.884 s Device
Service tedge-modbus-plugin should be enabled 0.182 s Device
Device should set supported operations for writing to registers and coils 0.177 s Operations
Device should write to a registers 2.580 s Operations
Device should write to a coil 2.577 s Operations
ChildDevice TestCase1 should have a Test.Int16 Measurement 0.358 s Telemetry
ChildDevice TestCase1 should have a Test.Float32 Measurement 0.358 s Telemetry
ChildDevice TestCase1 should have Alarms of type TestAlarm on Coil Value 1 0.001 s Telemetry

@zhongys-c8y
Copy link
Contributor Author

This approach should be the correct way to go rather than #46 . It will ignore messages on /cmd/ topic and won't change the payload if there is already a timestamp included

@reubenmiller reubenmiller added this pull request to the merge queue Oct 27, 2025
@reubenmiller reubenmiller changed the title Always add time into the telemetry payload feat: add time into the telemetry payload Oct 27, 2025
Merged via the queue into thin-edge:main with commit 0c7aa2f Oct 27, 2025
5 checks passed
@zhongys-c8y zhongys-c8y deleted the always-add-time branch October 27, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants