Upgrade React to 19.2.5 and lucide-react to 1.9.0#24
Merged
Conversation
React 18.2 → 19.2.5 is the Dependabot-proposed bump (PRs #5 and #6). lucide-react 0.303.0 → 1.9.0 is needed because 0.303.0 declares react@^16.5.1 || ^17.0.0 || ^18.0.0 as a peer dep, which blocks a clean npm install on React 19. 1.9.0 widens peer deps to include React 19. All icon imports used in src/ remain available. Verified: vitest 61/61 pass, vite build succeeds, dev server boots.
There was a problem hiding this comment.
Pull request overview
Updates frontend dependencies to support React 19 and resolve peer-dependency conflicts with lucide-react.
Changes:
- Bump
reactandreact-domfrom^18.2.0to^19.2.5 - Bump
lucide-reactfrom^0.303.0to^1.9.0(adds React 19 peer support)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do and why?
React 18.2 → 19.2.5 is the Dependabot-proposed bump (PRs #5 and #6). lucide-react 0.303.0 → 1.9.0 is needed because 0.303.0 declares react@^16.5.1 || ^17.0.0 || ^18.0.0 as a peer dep, which blocks a clean npm install on React 19. 1.9.0 widens peer deps to include React 19. All icon imports used in src/ remain available.
Verified: vitest 61/61 pass, vite build succeeds, dev server boots.
Scope of changes
Testing
How did you verify the change works? Include commands, steps, or screenshots.
python -m pytest tests/ -x -qpassesnpm run buildpasses (if frontend touched)Checklist
en.json/zh.json, backendbackend/i18n/locales/, iOSLocalizable.xcstrings).env.exampleAGENTS.md