[pull] develop from frappe:develop

hrms/hr/doctype/interview/interview.js

@@ -72,7 +72,7 @@ frappe.ui.form.on("Interview", {
 		frappe.call({
 			method: "hrms.hr.doctype.interview.interview.get_expected_skill_set",
 			args: {
-				interview_round: frm.doc.interview_round,
+				interview_type: frm.doc.interview_type,
 			},
 			callback: function (r) {
 				frm.events.show_feedback_dialog(frm, r.message);
@@ -198,15 +198,15 @@ frappe.ui.form.on("Interview", {
 		});
 	},
 
-	interview_round: function (frm) {
+	interview_type: function (frm) {
 		frm.set_value("job_applicant", "");
 		frm.trigger("set_applicable_interviewers");
 	},
 
 	job_applicant: function (frm) {
-		if (!frm.doc.interview_round) {
+		if (!frm.doc.interview_type) {
 			frm.set_value("job_applicant", "");
-			frappe.throw(__("Select Interview Round First"));
+			frappe.throw(__("Select Interview Type First"));
 		}
 
 		if (frm.doc.job_applicant && !frm.doc.designation) {
@@ -218,7 +218,7 @@ frappe.ui.form.on("Interview", {
 		frappe.call({
 			method: "hrms.hr.doctype.interview.interview.get_interviewers",
 			args: {
-				interview_round: frm.doc.interview_round || "",
+				interview_type: frm.doc.interview_type || "",
 			},
 			callback: function (r) {
 				frm.clear_table("interview_details");

hrms/hr/doctype/interview/interview.json

@@ -7,7 +7,7 @@
  "engine": "InnoDB",
  "field_order": [
   "interview_details_section",
-  "interview_round",
+  "interview_type",
   "job_applicant",
   "job_opening",
   "designation",
@@ -48,15 +48,6 @@
    "options": "Job Opening",
    "read_only": 1
   },
-  {
-   "fieldname": "interview_round",
-   "fieldtype": "Link",
-   "in_list_view": 1,
-   "in_standard_filter": 1,
-   "label": "Interview Round",
-   "options": "Interview Round",
-   "reqd": 1
-  },
   {
    "default": "Pending",
    "fieldname": "status",
@@ -102,7 +93,7 @@
    "label": "Details"
   },
   {
-   "fetch_from": "interview_round.expected_average_rating",
+   "fetch_from": "interview_type.expected_average_rating",
    "fieldname": "expected_average_rating",
    "fieldtype": "Rating",
    "label": "Expected Average Rating",
@@ -119,7 +110,7 @@
    "fieldtype": "Column Break"
   },
   {
-   "fetch_from": "interview_round.designation",
+   "fetch_from": "interview_type.designation",
    "fieldname": "designation",
    "fieldtype": "Link",
    "in_list_view": 1,
@@ -189,6 +180,15 @@
    "fieldtype": "Table",
    "label": "Interviewers",
    "options": "Interview Detail"
+  },
+  {
+   "fieldname": "interview_type",
+   "fieldtype": "Link",
+   "in_list_view": 1,
+   "in_standard_filter": 1,
+   "label": "Interview Type",
+   "options": "Interview Type",
+   "reqd": 1
   }
  ],
  "index_web_pages_for_search": 1,
@@ -199,11 +199,11 @@
    "link_fieldname": "interview"
   }
  ],
- "modified": "2025-11-21 17:24:02.676395",
+ "modified": "2026-02-19 15:40:38.547112",
  "modified_by": "Administrator",
  "module": "HR",
  "name": "Interview",
- "naming_rule": "Expression (old style)",
+ "naming_rule": "Expression",
  "owner": "Administrator",
  "permissions": [
   {

hrms/hr/doctype/interview/interview.py

@@ -32,8 +32,8 @@ class Interview(Document):
 		expected_average_rating: DF.Rating
 		from_time: DF.Time
 		interview_details: DF.Table[InterviewDetail]
-		interview_round: DF.Link
 		interview_summary: DF.Text | None
+		interview_type: DF.Link
 		job_applicant: DF.Link
 		job_opening: DF.Link | None
 		reminded: DF.Check
@@ -58,13 +58,13 @@ def on_submit(self):
 	def validate_duplicate_interview(self):
 		duplicate_interview = frappe.db.exists(
 			"Interview",
-			{"job_applicant": self.job_applicant, "interview_round": self.interview_round, "docstatus": 1},
+			{"job_applicant": self.job_applicant, "interview_type": self.interview_type, "docstatus": 1},
 		)
 
 		if duplicate_interview:
 			frappe.throw(
 				_(
-					"Job Applicants are not allowed to appear twice for the same Interview round. Interview {0} already scheduled for Job Applicant {1}"
+					"Job Applicants are not allowed to appear twice for the same Interview Type. Interview {0} already scheduled for Job Applicant {1}"
 				).format(
 					frappe.bold(get_link_to_form("Interview", duplicate_interview)),
 					frappe.bold(self.job_applicant),
@@ -77,8 +77,8 @@ def validate_designation(self):
 			if self.designation != applicant_designation:
 				frappe.throw(
 					_(
-						"Interview Round {0} is only for Designation {1}. Job Applicant has applied for the role {2}"
-					).format(self.interview_round, frappe.bold(self.designation), applicant_designation),
+						"Interview Type {0} is only for Designation {1}. Job Applicant has applied for the role {2}"
+					).format(self.interview_type, frappe.bold(self.designation), applicant_designation),
 					exc=DuplicateInterviewRoundError,
 				)
 		else:
@@ -155,8 +155,8 @@ def on_discard(self):
 
 
 @frappe.whitelist()
-def get_interviewers(interview_round: str) -> list[str]:
-	return frappe.get_all("Interviewer", filters={"parent": interview_round}, fields=["user as interviewer"])
+def get_interviewers(interview_type: str) -> list[dict]:
+	return frappe.get_all("Interviewer", filters={"parent": interview_type}, fields=["user as interviewer"])
 
 
 def get_recipients(name, for_feedback=0):
@@ -337,9 +337,9 @@ def send_daily_feedback_reminder():
 
 
 @frappe.whitelist()
-def get_expected_skill_set(interview_round: str) -> list[dict]:
+def get_expected_skill_set(interview_type: str):
 	return frappe.get_all(
-		"Expected Skill Set", filters={"parent": interview_round}, fields=["skill"], order_by="idx"
+		"Expected Skill Set", filters={"parent": interview_type}, fields=["skill"], order_by="idx"
 	)
 
 
@@ -424,7 +424,7 @@ def get_events(start: str, end: str, filters: str | None = None):
 	interviews = frappe.db.sql(
 		f"""
 			SELECT DISTINCT
-				`tabInterview`.name, `tabInterview`.job_applicant, `tabInterview`.interview_round,
+				`tabInterview`.name, `tabInterview`.job_applicant, `tabInterview`.interview_type,
 				`tabInterview`.scheduled_on, `tabInterview`.status, `tabInterview`.from_time as from_time,
 				`tabInterview`.to_time as to_time
 			from
@@ -441,7 +441,7 @@ def get_events(start: str, end: str, filters: str | None = None):
 
 	for d in interviews:
 		subject_data = []
-		for field in ["name", "job_applicant", "interview_round"]:
+		for field in ["name", "job_applicant", "interview_type"]:
 			if not d.get(field):
 				continue
 			subject_data.append(d.get(field))

hrms/hr/doctype/interview/test_interview.py

@@ -111,7 +111,7 @@ def test_get_interview_details_for_applicant_dashboard(self):
 			details.get("interviews").get(interview.name),
 			{
 				"name": interview.name,
-				"interview_round": interview.interview_round,
+				"interview_type": interview.interview_type,
 				"scheduled_on": interview.scheduled_on,
 				"average_rating": interview.average_rating * 5,
 				"status": "Pending",
@@ -221,7 +221,7 @@ def create_interview_and_dependencies(
 	create_user("test_interviewer1@example.com", "Interviewer")
 	create_user("test_interviewer2@example.com", "Interviewer")
 
-	interview_round = create_interview_round(
+	interview_type = create_interview_type(
 		"Technical Round",
 		["Python", "JS"],
 		["test_interviewer1@example.com", "test_interviewer2@example.com"],
@@ -230,7 +230,7 @@ def create_interview_and_dependencies(
 	)
 
 	interview = frappe.new_doc("Interview")
-	interview.interview_round = interview_round.name
+	interview.interview_type = interview_type.name
 	interview.job_applicant = job_applicant
 	interview.scheduled_on = scheduled_on or getdate()
 	interview.from_time = from_time or nowtime()
@@ -247,26 +247,25 @@ def create_interview_and_dependencies(
 	return interview
 
 
-def create_interview_round(name, skill_set, interviewers=None, designation=None, save=True):
+def create_interview_type(name, skill_set, interviewers=None, designation=None, save=True):
 	create_skill_set(skill_set)
-	interview_round = frappe.new_doc("Interview Round")
-	interview_round.round_name = name
-	interview_round.interview_type = create_interview_type()
+	interview_type = frappe.new_doc("Interview Type")
+	interview_type.interview_type_name = name
+	interview_type.description = "_Test_Description"
 	# average rating = 4
-	interview_round.expected_average_rating = 0.8
+	interview_type.expected_average_rating = 0.8
 	if designation:
-		interview_round.designation = designation
+		interview_type.designation = designation
 
 	for skill in skill_set:
-		interview_round.append("expected_skill_set", {"skill": skill})
+		interview_type.append("expected_skill_set", {"skill": skill})
 
 	for interviewer in interviewers:
-		interview_round.append("interviewers", {"user": interviewer})
+		interview_type.append("interviewers", {"user": interviewer})
 
 	if save:
-		interview_round.save()
-
-	return interview_round
+		interview_type.save()
+	return interview_type
 
 
 def create_skill_set(skill_set):
@@ -277,18 +276,6 @@ def create_skill_set(skill_set):
 			doc.save()
 
 
-def create_interview_type(name="test_interview_type"):
-	if frappe.db.exists("Interview Type", name):
-		return frappe.get_doc("Interview Type", name).name
-	else:
-		doc = frappe.new_doc("Interview Type")
-		doc.name = name
-		doc.description = "_Test_Description"
-		doc.save()
-
-		return doc.name
-
-
 def setup_reminder_settings():
 	if not frappe.db.exists("Email Template", _("Interview Reminder")):
 		base_path = frappe.get_app_path("erpnext", "hr", "doctype")

hrms/hr/doctype/interview_feedback/interview_feedback.js

@@ -14,11 +14,11 @@ frappe.ui.form.on("Interview Feedback", {
 		});
 	},
 
-	interview_round: function (frm) {
+	interview_type: function (frm) {
 		frappe.call({
 			method: "hrms.hr.doctype.interview.interview.get_expected_skill_set",
 			args: {
-				interview_round: frm.doc.interview_round,
+				interview_type: frm.doc.interview_type,
 			},
 			callback: function (r) {
 				frm.set_value("skill_assessment", r.message);

hrms/hr/doctype/interview_feedback/interview_feedback.json

@@ -8,7 +8,7 @@
  "field_order": [
   "details_section",
   "interview",
-  "interview_round",
+  "interview_type",
   "job_applicant",
   "column_break_3",
   "interviewer",
@@ -31,18 +31,6 @@
    "options": "Interview",
    "reqd": 1
   },
-  {
-   "allow_in_quick_entry": 1,
-   "fetch_from": "interview.interview_round",
-   "fieldname": "interview_round",
-   "fieldtype": "Link",
-   "in_list_view": 1,
-   "in_standard_filter": 1,
-   "label": "Interview Round",
-   "options": "Interview Round",
-   "read_only": 1,
-   "reqd": 1
-  },
   {
    "allow_in_quick_entry": 1,
    "fieldname": "interviewer",
@@ -118,16 +106,28 @@
    "label": "Job Applicant",
    "options": "Job Applicant",
    "read_only": 1
+  },
+  {
+   "allow_in_quick_entry": 1,
+   "fetch_from": "interview.interview_type",
+   "fieldname": "interview_type",
+   "fieldtype": "Link",
+   "in_list_view": 1,
+   "in_standard_filter": 1,
+   "label": "Interview Type",
+   "options": "Interview Type",
+   "read_only": 1,
+   "reqd": 1
   }
  ],
  "index_web_pages_for_search": 1,
  "is_submittable": 1,
  "links": [],
- "modified": "2024-03-27 13:09:51.973613",
+ "modified": "2026-02-19 16:31:33.463199",
  "modified_by": "Administrator",
  "module": "HR",
  "name": "Interview Feedback",
- "naming_rule": "Expression (old style)",
+ "naming_rule": "Expression",
  "owner": "Administrator",
  "permissions": [
   {
@@ -164,9 +164,10 @@
   }
  ],
  "quick_entry": 1,
+ "row_format": "Dynamic",
  "sort_field": "creation",
  "sort_order": "DESC",
  "states": [],
  "title_field": "interviewer",
  "track_changes": 1
-}
+}

hrms/hr/doctype/interview_feedback/interview_feedback.py

@@ -24,7 +24,7 @@ class InterviewFeedback(Document):
 		average_rating: DF.Rating
 		feedback: DF.Text | None
 		interview: DF.Link
-		interview_round: DF.Link
+		interview_type: DF.Link
 		interviewer: DF.Link
 		job_applicant: DF.Link | None
 		result: DF.Literal["", "Cleared", "Rejected"]

hrms/hr/doctype/interview_feedback/test_interview_feedback.py

@@ -19,7 +19,7 @@ def test_validation_for_skill_set(self):
 		interview = create_interview_and_dependencies(
 			job_applicant.name, scheduled_on=add_days(getdate(), -1)
 		)
-		skill_ratings = get_skills_rating(interview.interview_round)
+		skill_ratings = get_skills_rating(interview.interview_type)
 
 		interviewer = "test_interviewer1@example.com"
 		create_skill_set(["Leadership"])
@@ -37,7 +37,7 @@ def test_average_ratings_on_feedback_submission_and_cancellation(self):
 		interview = create_interview_and_dependencies(
 			job_applicant.name, scheduled_on=add_days(getdate(), -1)
 		)
-		skill_ratings = get_skills_rating(interview.interview_round)
+		skill_ratings = get_skills_rating(interview.interview_type)
 
 		# For First Interviewer Feedback
 		interviewer = "test_interviewer1@example.com"
@@ -85,10 +85,10 @@ def create_interview_feedback(interview, interviewer, skills_ratings):
 	return interview_feedback
 
 
-def get_skills_rating(interview_round):
+def get_skills_rating(interview_type):
 	import random
 
-	skills = frappe.get_all("Expected Skill Set", filters={"parent": interview_round}, fields=["skill"])
+	skills = frappe.get_all("Expected Skill Set", filters={"parent": interview_type}, fields=["skill"])
 	for d in skills:
 		d["rating"] = random.random()
 	return skills