Skip to content

fix(read): stop claiming a wrong password burns a read #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thoda-dev merged 2 commits into from
Aug 28, 2026
Merged

fix(read): stop claiming a wrong password burns a read #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d5b47a
fix(read): stop claiming a wrong password burns a read
thoda-dev Aug 28, 2026
c773dea
docs(read): note the legacy unlock-hash branch in the burn warning co…
thoda-dev Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/app/app/pages/p/[id].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ const metaError = ref('')
const meta = ref<MetaResponse | null>(null)
const fragmentKey = ref<Bytes | null>(null)

// Only where there is a password, and only for pastes carrying an unlock hash: `reveal.post.ts`
// spends nothing on a wrong one, but its `isNull` legacy branch still burns a read.
const burnWarning = computed(() => [
t('read.burnWarningDescription'),
...(meta.value?.passwordProtected ? [t('read.burnWarningPassword')] : [])
].join(' '))

onMounted(async () => {
const keyParam = new URLSearchParams(window.location.hash.replace(/^#/, '')).get('key')
if (!keyParam) {
Expand Down Expand Up @@ -174,7 +181,7 @@ async function copyText() {
color="warning"
variant="subtle"
:title="t('read.burnWarningTitle')"
:description="t('read.burnWarningDescription')"
:description="burnWarning"
/>
<UAlert
v-if="revealError"
Expand Down
3 changes: 2 additions & 1 deletion apps/app/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
"readsRemaining": "Reads remaining: {count}",
"passwordLabel": "This paste is password protected",
"burnWarningTitle": "Revealing consumes one read",
"burnWarningDescription": "Once revealed, this counts against the paste's read limit — even if the password turns out to be wrong.",
"burnWarningDescription": "Once revealed, this counts against the paste's read limit.",
"burnWarningPassword": "A wrong password costs nothing: the read is only spent once the password is right.",
"reveal": "Reveal",
"copyText": "Copy",
"downloadFile": "Download {name}",
Expand Down
3 changes: 2 additions & 1 deletion apps/app/i18n/locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
"readsRemaining": "Lectures restantes : {count}",
"passwordLabel": "Ce paste est protégé par un mot de passe",
"burnWarningTitle": "Révéler consomme une lecture",
"burnWarningDescription": "Une fois révélé, ceci compte dans la limite de lectures du paste — même si le mot de passe s'avère incorrect.",
"burnWarningDescription": "Une fois révélé, ceci compte dans la limite de lectures du paste.",
"burnWarningPassword": "Un mot de passe incorrect ne coûte rien : la lecture n'est décomptée qu'avec le bon mot de passe.",
"reveal": "Révéler",
"copyText": "Copier",
"downloadFile": "Télécharger {name}",
Expand Down