Add environment variable overrides for llama.cpp launches - #379
Merged
Merged
Conversation
- Validate and propagate LLAMA_/GGML_ settings across launch flows - Add Configure UI, preset support, and coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an advanced Environment Variables panel for configuring per-launch
LLAMA_andGGML_overrides. Values are shared across Configure, Quick Launch, chat/model switching, benchmarking, memory estimation, and presets, then validated and applied only to the launched child process.Scope
This does not support shell expansion or execution,
LLAMA_GUI_/LLAMA_ARG_settings, or environment-variable comparison and revert controls. Existing command-line argument controls remain the source of truth for GUI and CLI-managed options.Verification
node tests/frontend/custom_launch_args_unit.cjstests/backend/test_process_environment.pycovering validation, propagation, inherited values, runtime paths, and process-environment isolationUI evidence
The Configure tab now includes an Environment Variables panel below Custom Launch Args, with inline validation and guidance for supported variable names and literal values.