Fix running cadence display in activities overview - #1251
Open
mariusc wants to merge 1 commit into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 26 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for Elevate, I've been using it for a few years now and it's great 🙌.
Since Strava introduced limits and only premium subscribers can now use the Strava API, I had to find another way to import my activities into Elevate, so I'm now exporting them as .fit from Health and importing them from a folder. All that to say that, for the first time ever, I now have cadence data on my runs 😂.
This made me realise that in the table of activities, a wrong value for cadence is shown. While the activity details show the correct value, the one in the activity table is half of it.
Digging deeper, it seemed to be related to the
enableBothLegsCadencethat was introduced in c80bb34, which was applied only to the activity details view, and not to the activity table as well.Fixes #1204 (I think)
I will be very honest and say that I am a developer, but I'm not familiar with Angular or typescript, and this patch was done mostly with (by) Codex. Let me know what you think.